Do not fail the build if cleaning fails - Warn only#71
Merged
Conversation
Member
|
I'm not sure if this change is going to fix the issue, but it shouldn't make it worse. In case of doubt, I merge it :-D (LGTM) |
Member
|
I deployed the new config, we will see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some investigation, the reason builds like:
https://buildbot.python.org/all/#/builders/16/builds/2013
reported a failure after #69 is not because of a configuration failure, but because the clean step also failed. Notice that clean has
alwaysRuns=True, and according to the docs:The clean step was marked as
warnOnFailure = Truebut notflunkOnFailure = Falseso an error was reported.This PR fixes this by only warning if the clean step fails.